Module:Protection banner: Difference between revisions

Module:Protection banner (edit)

Revision as of 18:19, 28 June 2014

94 bytes removed , 10 years ago

condense _main and switch Blurb arg order

Anonymous user

wikipedia>Jackmcbarn

@@ Line 339: / Line 339: @@
 local Blurb = class('Blurb')
-function Blurb:initialize(cfg, protectionObj)
+function Blurb:initialize(protectionObj, cfg)
 	self._cfg = cfg
 	self._protectionObj = protectionObj
@@ Line 894: / Line 894: @@
 	-- Initialise protection and blurb objects
 	local protectionObj = Protection:new(args, cfg)
-	local blurbObj = Blurb:new(cfg, protectionObj)
+	local blurbObj = Blurb:new(protectionObj, cfg)
 	blurbObj:setDeletionDiscussionPage(args.xfd)
 	blurbObj:setUsername(args.user)
@@ Line 904: / Line 904: @@
 	if protectionObj:isProtected() then
 		-- Get the banner object
-		local isPadlock = yesno(args.small)
 		local bannerObj
-		if isPadlock then
+		if yesno(args.small) then
 			bannerObj = Padlock:new(cfg)
-		else
-			bannerObj = Banner:new(cfg)
-		end
-		-- Set the image fields
-		local bannerConfig = protectionObj.bannerConfig
-		bannerObj:setImageFilename(bannerConfig.image, protectionObj)
-		if isPadlock then
 			bannerObj:setImageTooltip(blurbObj:makeTooltipText())
 			bannerObj:setImageAlt(blurbObj:makeAltText())
 			bannerObj:setImageLink(blurbObj:makeLinkText())
 		else
+			bannerObj = Banner:new(cfg)
 			-- Large banners use the alt text for the tooltip.
 			bannerObj:setImageTooltip(blurbObj:makeAltText())
-		end
+			-- Set the text fields and the page name.
-		-- Set the text fields and the page name.
-		if not isPadlock then
 			bannerObj:setReasonText(blurbObj:makeReasonText())
 			bannerObj:setExplanationText(blurbObj:makeExplanationText())
 			bannerObj:setPage(protectionObj.title.prefixedText)
 		end
+		-- Set the image fields
+		local bannerConfig = protectionObj.bannerConfig
+		bannerObj:setImageFilename(bannerConfig.image, protectionObj)
 		ret[#ret + 1] = tostring(bannerObj)