Module:Check for unknown parameters: Difference between revisions
various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster)
m>Mr. Stradivarius (fix substitution of "_VALUE_" when it isn't followed by a space) |
m>Mr. Stradivarius (various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster)) |
||
| Line 3: | Line 3: | ||
-- not on the list | -- not on the list | ||
local p = {} | local p = {} | ||
local function trim(s) | |||
return s:match('^%s*(.-)%s*$') | |||
end | |||
local function isnotempty(s) | local function isnotempty(s) | ||
return s and | return s and trim(s) ~= '' | ||
end | end | ||
| Line 24: | Line 28: | ||
for k, v in pairs(args) do | for k, v in pairs(args) do | ||
if type(k) == 'number' then | if type(k) == 'number' then | ||
v = | v = trim(v) | ||
knownargs[v] = 1 | knownargs[v] = 1 | ||
elseif k == 'unknown' then | |||
unknown = v | |||
elseif k:find('^regexp[1-9][0-9]*$') then | |||
table.insert(regexps, '^' .. v .. '$') | |||
end | end | ||
end | end | ||
-- adds one result to the output tables | |||
local function addresult(k) | local function addresult(k) | ||
if k == '' then | if k == '' then | ||
| Line 41: | Line 44: | ||
k = ' ' | k = ' ' | ||
end | end | ||
local r = | local r = unknown:gsub('_VALUE_', k) | ||
table.insert(res, r) | table.insert(res, r) | ||
table.insert(comments, '"' .. k .. '"') | table.insert(comments, '"' .. k .. '"') | ||
| Line 47: | Line 50: | ||
-- loop over the parent args, and make sure they are on the list | -- loop over the parent args, and make sure they are on the list | ||
for k,v in pairs(pargs) do | for k, v in pairs(pargs) do | ||
if | if type(k) == 'string' and knownargs[k] == nil then | ||
local knownflag = | local knownflag = false | ||
for | for i, regexp in ipairs(regexps) do | ||
if | if mw.ustring.match(k, regexp) then | ||
knownflag = | knownflag = true | ||
break | |||
end | end | ||
end | end | ||
if | if not knownflag and ( not ignoreblank or isnotempty(v) ) then | ||
k = mw.ustring.gsub(k, '[^%w\-_ ]', '?') | k = mw.ustring.gsub(k, '[^%w\-_ ]', '?') | ||
addresult(k) | addresult(k) | ||
end | end | ||
elseif | elseif checkpos and | ||
type(k) == 'number' and | |||
knownargs[tostring(k)] == nil and | |||
( not ignoreblank or isnotempty(v) ) | |||
then | |||
addresult(k) | |||
end | end | ||
end | end | ||
if | if #comments > 0 then | ||
commentstr = '<!-- Module:Check for unknown parameters results: ' .. | commentstr = '<!-- Module:Check for unknown parameters results: ' .. | ||
table.concat(comments, ', ') .. '-->' | table.concat(comments, ', ') .. '-->' | ||