Jump to content

Module:Check for unknown parameters: Difference between revisions

various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster)
m>Mr. Stradivarius
(fix substitution of "_VALUE_" when it isn't followed by a space)
m>Mr. Stradivarius
(various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster))
Line 3: Line 3:
-- not on the list
-- not on the list
local p = {}
local p = {}
local function trim(s)
return s:match('^%s*(.-)%s*$')
end


local function isnotempty(s)
local function isnotempty(s)
return s and s:match( '^%s*(.-)%s*$' ) ~= ''
return s and trim(s) ~= ''
end
end


Line 24: Line 28:
for k, v in pairs(args) do
for k, v in pairs(args) do
if type(k) == 'number' then
if type(k) == 'number' then
v = mw.ustring.gsub(v, '^%s*(.-)%s*$', '%1')
v = trim(v)
knownargs[v] = 1
knownargs[v] = 1
else
elseif k == 'unknown' then
if (k == 'unknown' and type(v) == 'string') then
unknown = v
unknown = v
elseif k:find('^regexp[1-9][0-9]*$') then
elseif (mw.ustring.match(k, '^regexp[%d]*$') and type(v) == 'string') then
table.insert(regexps, '^' .. v .. '$')
table.insert(regexps, '^' .. v .. '$')
end
end
end
end
end


-- adds one result to the output tables
local function addresult(k)
local function addresult(k)
if k == '' then
if k == '' then
Line 41: Line 44:
k = ' '
k = ' '
end
end
local r = mw.ustring.gsub(unknown, '_VALUE_', k)
local r = unknown:gsub('_VALUE_', k)
table.insert(res, r)
table.insert(res, r)
table.insert(comments, '"' .. k .. '"')
table.insert(comments, '"' .. k .. '"')
Line 47: Line 50:


-- loop over the parent args, and make sure they are on the list
-- loop over the parent args, and make sure they are on the list
for k,v in pairs(pargs) do
for k, v in pairs(pargs) do
if (type(k) == 'string' and knownargs[k] == nil) then
if type(k) == 'string' and knownargs[k] == nil then
local knownflag = nil
local knownflag = false
for r = 1,#regexps do
for i, regexp in ipairs(regexps) do
if( mw.ustring.match(k,regexps[r]) ) then
if mw.ustring.match(k, regexp) then
knownflag = 1
knownflag = true
break
end
end
end
end
if( (not knownflag) and ( (not ignoreblank) or (ignoreblank and isnotempty(v)) ) ) then
if not knownflag and ( not ignoreblank or isnotempty(v) ) then
k = mw.ustring.gsub(k, '[^%w\-_ ]', '?')
k = mw.ustring.gsub(k, '[^%w\-_ ]', '?')
addresult(k)
addresult(k)
end
end
elseif(checkpos and type(k) == 'number' and knownargs[tostring(k)] == nil) then
elseif checkpos and
if( (not ignoreblank) or (ignoreblank and isnotempty(v)) ) then
type(k) == 'number' and  
addresult(k)
knownargs[tostring(k)] == nil and
end
( not ignoreblank or isnotempty(v) )
then
addresult(k)
end
end
end
end


if(#comments > 0) then
if #comments > 0 then
commentstr = '<!-- Module:Check for unknown parameters results: ' ..
commentstr = '<!-- Module:Check for unknown parameters results: ' ..
table.concat(comments, ', ') .. '-->'
table.concat(comments, ', ') .. '-->'
Anonymous user
Cookies help us deliver our services. By using our services, you agree to our use of cookies.